Open
Conversation
Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>
Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>
Member
|
@copilot please skip the special-words tests in tspcompile.tsp, it's waiting for the fix: microsoft/typespec#9987 |
Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>
Contributor
Author
Commented out |
Member
|
@copilot please redo this task |
Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>
Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>
Contributor
Author
Redone the full upgrade from scratch in c98b60f. Key changes:
|
Member
|
@copilot please help find the original typespec and mockapi.ts files for the newly added test and add spector test for them. |
Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>
Contributor
Author
Added spector tests for all newly generated test cases in 12633d7:
|
JiaqiZhang-Dev
requested review from
ArcturusZhang,
RickWinter,
chlowell,
jhendrixMSFT,
lirenhe and
tadelesh
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TypeSpec toolchain versions used by packages/typespec-go, refreshes the pnpm lockfile, and regenerates/extends the Go test fixtures to match the new emitted output across http-specs, azure-http-specs, and local azblob tests.
Changes:
- Bumped TypeSpec + Azure toolset dependencies in
packages/typespec-go/package.jsonand updatedpnpm-lock.yaml. - Regenerated Go test clients/models/fakes to reflect updated emitter/tooling output (including new special-words and XML payload cases).
- Added/updated tests for newly generated scenarios and updated
CHANGELOG.mdfor0.10.3.
Reviewed changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Locks updated dependency graph for the new TypeSpec/Azure toolset versions. |
| packages/typespec-go/package.json | Updates dev/peer deps to latest TypeSpec and Azure generator packages; bumps pnpm version. |
| packages/typespec-go/CHANGELOG.md | Adds 0.10.3 “Other Changes” note for the toolset upgrade. |
| packages/typespec-go/test/local/azblob/zz_service_client.go | Regenerated azblob service client request URL construction. |
| packages/typespec-go/test/local/azblob/zz_pageblob_client.go | Regenerated page blob client request URL construction. |
| packages/typespec-go/test/local/azblob/zz_container_client.go | Regenerated container client request URL construction. |
| packages/typespec-go/test/local/azblob/zz_client.go | Regenerated blob client request URL construction. |
| packages/typespec-go/test/local/azblob/zz_blockblob_client.go | Regenerated block blob client request URL construction. |
| packages/typespec-go/test/local/azblob/zz_appendblob_client.go | Regenerated append blob client request URL construction. |
| packages/typespec-go/test/http-specs/specialwordsgroup/zz_specialwordsextensiblestrings_client.go | New generated client for extensible-string special-words scenario. |
| packages/typespec-go/test/http-specs/specialwordsgroup/zz_specialwords_client.go | Adds accessor for the new SpecialWordsExtensibleStringsClient. |
| packages/typespec-go/test/http-specs/specialwordsgroup/zz_responses.go | Adds response envelope type for new special-words operation. |
| packages/typespec-go/test/http-specs/specialwordsgroup/zz_options.go | Adds options type for new special-words operation. |
| packages/typespec-go/test/http-specs/specialwordsgroup/zz_constants.go | Adds extensible enum constants for special-word string values. |
| packages/typespec-go/test/http-specs/specialwordsgroup/fake/zz_specialwordsextensiblestrings_server.go | Adds fake server transport for the new special-words client. |
| packages/typespec-go/test/http-specs/specialwordsgroup/fake/zz_specialwords_server.go | Wires new special-words server transport into the top-level fake server. |
| packages/typespec-go/test/http-specs/specialwordsgroup/extensiblestrings_client_test.go | Adds spector-style test for PutExtensibleStringValue. |
| packages/typespec-go/test/http-specs/payload/xmlgroup/zz_xmlmodelwithenumvalue_client.go | New generated XML client for model-with-enum payload. |
| packages/typespec-go/test/http-specs/payload/xmlgroup/zz_xmlmodelwithdatetimevalue_client.go | New generated XML client for model-with-datetime payload. |
| packages/typespec-go/test/http-specs/payload/xmlgroup/zz_xml_client.go | Adds accessors for the newly generated XML sub-clients. |
| packages/typespec-go/test/http-specs/payload/xmlgroup/zz_responses.go | Adds response envelopes for the new XML operations. |
| packages/typespec-go/test/http-specs/payload/xmlgroup/zz_options.go | Adds options types for the new XML operations. |
| packages/typespec-go/test/http-specs/payload/xmlgroup/zz_models_serde.go | Adds XML marshal/unmarshal for the new datetime model using azcore datetime helpers. |
| packages/typespec-go/test/http-specs/payload/xmlgroup/zz_models.go | Adds new XML models (datetime + enum). |
| packages/typespec-go/test/http-specs/payload/xmlgroup/zz_constants.go | Adds enum constants for XML model-with-enum scenario. |
| packages/typespec-go/test/http-specs/payload/xmlgroup/xmlmodelwithenumvalue_client_test.go | Adds tests for XML ModelWithEnum Get/Put. |
| packages/typespec-go/test/http-specs/payload/xmlgroup/xmlmodelwithdatetimevalue_client_test.go | Adds tests for XML ModelWithDatetime Get; Put skipped due to known RFC1123 GMT/UTC mismatch. |
| packages/typespec-go/test/http-specs/payload/xmlgroup/fake/zz_xmlmodelwithenumvalue_server.go | Adds fake transport for XML ModelWithEnum client. |
| packages/typespec-go/test/http-specs/payload/xmlgroup/fake/zz_xmlmodelwithdatetimevalue_server.go | Adds fake transport for XML ModelWithDatetime client. |
| packages/typespec-go/test/http-specs/payload/xmlgroup/fake/zz_xml_server.go | Wires new XML sub-client fake transports into the XML fake server. |
| packages/typespec-go/test/azure-http-specs/azure/core/azurepagegroup/zz_responses.go | Adds response type for relative-nextLink pager scenario. |
| packages/typespec-go/test/azure-http-specs/azure/core/azurepagegroup/zz_page_client.go | Adds generated pager for WithRelativeNextLink scenario. |
| packages/typespec-go/test/azure-http-specs/azure/core/azurepagegroup/zz_options.go | Adds options type for WithRelativeNextLink pager. |
| packages/typespec-go/test/azure-http-specs/azure/core/azurepagegroup/fake/zz_page_server.go | Adds fake paging support for WithRelativeNextLink pager. |
| packages/typespec-go/test/azure-http-specs/azure/core/azurepagegroup/custom_client_test.go | Adds (commented-out) test coverage for relative nextLink paging due to runtime limitation. |
| packages/typespec-go/test/azure-http-specs/azure/client-generator-core/flattengroup/zz_responses.go | Adds response envelopes for new flatten test operations. |
| packages/typespec-go/test/azure-http-specs/azure/client-generator-core/flattengroup/zz_options.go | Adds options types for new flatten test operations. |
| packages/typespec-go/test/azure-http-specs/azure/client-generator-core/flattengroup/zz_models_serde.go | Adds JSON serde for new models, including unknown-type flattening support. |
| packages/typespec-go/test/azure-http-specs/azure/client-generator-core/flattengroup/zz_models.go | Adds new flatten models (unknown + read-only flattened). |
| packages/typespec-go/test/azure-http-specs/azure/client-generator-core/flattengroup/zz_flattenproperty_client.go | Adds new client operations for flatten read-only and flatten unknown models. |
| packages/typespec-go/test/azure-http-specs/azure/client-generator-core/flattengroup/flattenproperty_client_test.go | Adds tests for the new flatten operations. |
| packages/typespec-go/test/azure-http-specs/azure/client-generator-core/flattengroup/fake/zz_flattenproperty_server.go | Adds fake server handlers for the new flatten operations. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
packages/typespec-go/test/azure-http-specs/azure/core/azurepagegroup/zz_page_client.go
Show resolved
Hide resolved
tadelesh
approved these changes
Mar 16, 2026
jhendrixMSFT
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgraded all TypeSpec toolset dependencies to their latest versions:
Key Version Changes
@typespec/compiler: 1.9.0 → 1.10.0@typespec/http: 1.9.1 → 1.10.0@azure-tools/typespec-client-generator-core: 0.65.4 → 0.66.2@azure-tools/typespec-azure-core: 0.65.0 → 0.66.0@azure-tools/typespec-azure-resource-manager: 0.65.0 → 0.66.0@azure-tools/typespec-autorest: 0.65.0 → 0.66.0@azure-tools/azure-http-specs: 0.1.0-alpha.37 → 0.1.0-alpha.38@typespec/http-specs: 0.1.0-alpha.32 → 0.1.0-alpha.34@typespec/*packages from 0.79.0 → 0.80.0Changes
devDependenciesandpeerDependenciesinpackages/typespec-go/package.jsonpnpm-lock.yamlpnpm tspcompile(includingspecialwordsgroup)CHANGELOG.mdwith version 0.10.3 entrySpector Tests Added
Added spector tests for all newly generated test cases from the upgrade:
ModelWithDatetimeValue(Get; Put skipped due to UTC/GMT mismatch indatetime.RFC1123),ModelWithEnumValue(Get/Put)ExtensibleStrings.PutExtensibleStringValuePutFlattenUnknownModel,PutFlattenReadOnlyModelWithRelativeNextLink(commented out —runtime.FetcherForNextLinkdoesn't support relative URLs)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.